totten / civix

CiviCRM Extension Builder
http://civicrm.org/
Other
57 stars 56 forks source link

Unconditionally prompts upgrade to EFv2 #372

Open colemanw opened 5 days ago

colemanw commented 5 days ago

When upgrading the SearchKit Reports extension from v23.02.1 => v24.09.1 I was prompted to upgrade to EFv2. That's nice, but the extension has no entity types. I typed "y", expecting nothing to happen, but <mixin>entity-types-php@2.0.0</mixin> was added to the info.xml and the shim entity-types-php@2.0.0.mixin.php was added to the mixin directory. I manually deleted these after the upgrade because they're irrelevant to an extension with no entities.

@totten I'm concerned that developers upgrading their extensions will wind up with a bunch of irrelevant mixins and shims in the process.