search

touchlab / DroidconKotlin

Kotlin Multiplatfom app for Droidcon Events
https://touchlab.co
Apache License 2.0
1.02k stars 79 forks source link

Migrate to material3 #211

Closed serbelga closed 11 months ago

serbelga commented 11 months ago

This is a proposal to use Material 3 in the :shared-ui module.

I've been trying to use Material3 Compose components and themes in the views of the shared-ui module.

The colors are generated from the Figma Material Theme Builder plugin https://www.figma.com/community/plugin/1034969338659738588/material-theme-builder. To improve visibility on light surfaces, I have set the blue that was being used as a secondary color as the primary color and the green that was used as the primary color as the secondary color.

Also, I have added the Montserrat font to adopt the same font used on the Droidcon website.

ℹ️ I have removed the two lines that specified the color of the status bar and navigation bar in themes.xml in the android module until using version 1.8.0 of Activity Compose that allows using the edgeToEdgeEnabled() method.

ℹ️ I haven't migrated views in android module to Material3 because they seem to not been used and will be removed in https://github.com/touchlab/DroidconKotlin/pull/212

Android

Light Theme

Dark Theme

iOS

Light Theme

Dark Theme
kpgalligan commented 11 months ago

Thanks for the PR! I think I confused github as I merged after a rebase and some minor changes, but this is still "open". I assumed it would figure out that it was merged. Will see if I can get github to recognize that without closing it.

serbelga commented 11 months ago

I synced my branch with the latest changes to main and it automatically closed this PR. I see that my commits are now on the main branch. https://github.com/touchlab/DroidconKotlin/commits?author=serbelga