tovid-suite / tovid

Suite of tools for DVD authoring
http://tovid.wikia.com/wiki/Tovid_Wiki
GNU General Public License v2.0
7 stars 4 forks source link

ffmpeg aspect parameter selection in todisc does not work #164

Closed tovid-suite closed 9 years ago

tovid-suite commented 9 years ago

From c...@mondueri.com on November 27, 2013 16:03:38

In r3497 , todisc line 3786 ( https://code.google.com/p/tovid/source/browse/trunk/tovid/src/todisc#3786 ) there is this check and it's not working: if grep -qw ^setdar <<< "$ff_filters"; then

The problem seems to be that 'setdar' does not appear as the beginning of a line (^setdar) because $ff_filters is a list, as show in line 3781, which is converted to a single line of strings separated by spaces. ff_filters=$($FFmpeg -filters 2>/dev/null | awk 'f;/Filters:/{f=1}')

The same happens for all the other filter parameters to ffmpeg with ^ at the beginning.

Sorry if I'm missing something.

Thanks!

Original issue: http://code.google.com/p/tovid/issues/detail?id=165

tovid-suite commented 9 years ago

From grepper@gmail.com on February 28, 2014 10:41:29

Hi. Sorry it has taken so long to respond. Thanks for reporting this - I actually fixed it 2 days later in SVN and I just noticed I didn't update this issue. Please report if the fix doesn't work for you - otherwise I will close this issue.

Thanks again for the report! grepper

Owner: grepper@gmail.com

tovid-suite commented 9 years ago

From grepper@gmail.com on May 20, 2014 18:08:44

Status: Fixed