tpaviot / pythonocc-core

Python package for 3D geometry CAD/BIM/CAM
GNU Lesser General Public License v3.0
1.39k stars 380 forks source link

Fix azure-build (conda osx missing and MeshDS test segfault) #1376

Closed tpaviot closed 1 month ago

tpaviot commented 1 month ago

Summary by Sourcery

Update the conda build configuration to use newer versions of Ubuntu and Python, add Miniconda installation steps for macOS, and fix a segmentation fault in the MeshDS test by removing the problematic import.

Bug Fixes:

Enhancements:

CI:

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request addresses issues with the Azure build pipeline, specifically focusing on conda build for macOS and updating the Ubuntu image. It also removes a potentially problematic test import.

Architecture diagram for updated Azure build pipeline

graph TD;
    A[Azure Pipeline] -->|Uses| B[conda-build.yml];
    B -->|Updated| C[Ubuntu 22.04];
    B -->|Added| D[macOS Miniconda Installation];
    B -->|Added| E[Ubuntu 24.04];
    C --> F[Python 3.9];
    E --> G[Python 3.10];
    D --> H[Python 3.10];

Class diagram for conda meta.yaml changes

classDiagram
    class MetaYaml {
        -OCC
        -OCC.Core.BRepPrimAPI
        -OCC.Core.MeshDS
        -OCC.Core.Tesselator
        -pyqt >=5
    }
    note for MetaYaml "Removed OCC.Core.MeshDS import"

File-Level Changes

Change Details Files
Update conda build configuration for macOS
  • Add steps to install Miniconda on macOS
  • Configure conda initialization for macOS
  • Separate macOS and Ubuntu conda PATH configuration
conda-build.yml
Update Ubuntu image and Python versions
  • Change Ubuntu image from 18.04 to 22.04
  • Update Python version from 3.6 to 3.9
  • Add new job for Ubuntu 24.04 with Python 3.10
conda-build.yml
azure-pipelines.yml
Remove MeshDS test import
  • Remove 'OCC.Core.MeshDS' from test imports
ci/conda/meta.yaml

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).