tposney / midi-qol

Other
5 stars 0 forks source link

HP and features not delete when class is deleted #1228

Closed tposney closed 1 year ago

tposney commented 1 year ago

In GitLab by @cardosomafrasantana on Apr 16, 2023, 14:50

When you delete a class from an actor sheet, it will not delete the others features of that class and it will bug the HP forever for that sheet, never updating the Max HP.

I check early and this only occurs when Midi QOL and libWrapper are active together.

tposney commented 1 year ago

In GitLab by @cardosomafrasantana on Apr 16, 2023, 15:38

Digging more with some people on Discord, we found that the option Item Delete Check are causing this. This option did not resets the HP when the class are deleted, causing all this trouble.

tposney commented 1 year ago

In GitLab by @Krigsmaskine on Apr 16, 2023, 15:47

Additional note: Is item delete check even needed anymore? DnD5e or Foundry core seems to have this implemented already when I test on a fresh world.

tposney commented 1 year ago

In GitLab by @cardosomafrasantana on Apr 16, 2023, 15:54

Okay, flash news: If that bug happen with Tidy5eSheet and you edit the Current HP and Max HP direcly to 0, it will not update anymore.

tposney commented 1 year ago

I don't think it's needed anymore - I'll just remove it.