search

tpreynolds / uw_hs1_adcs

Development of ADCS flight software for the HuskySat-1 mission at the University of Washington.
0 stars 2 forks source link

Emma sprint20 #16

Closed e-vic closed 6 years ago

e-vic commented 6 years ago

Fixed PD controller stability .... there was a misplaced minus... it stabilizes the system now. Still need to be tested further though

MathiasKerman commented 6 years ago

Sounds good, I'll review this tomorrow in the lab

tpreynolds commented 6 years ago

yay for stability! Sorry for flipping a minus sign, but good catch.

Can we/you check this against my pull-req so that we bring develop up to where it has both my changes and the magnetic PD controller?

MathiasKerman commented 6 years ago

Sure, will do. I'll have to do it tomorrow morning, though.

e-vic commented 6 years ago

@tpreynolds I'm pretty sure the minus sign was an error of mine, you're good ahah

tpreynolds commented 6 years ago

Just like Mathias' branch .. let's make pull req's when we have stable things to merge. I want to keep develop as close to "deployable" as possible real soon, so only tested code should go in.

Just keep this branch going and re-open the pull req when we've had a chance to work out the pointing errors we saw the other day. This should be a top priority this week (let's pull in someone from DS1 maybe)