show most recent available daily results regardless of date

tracking-exposed / facebook

facebook.tracking.exposed - collaborative tool for algorithm investigation

https://facebook.tracking.exposed

GNU Affero General Public License v3.0

113 stars 39 forks source link

show most recent available daily results regardless of date #144

Closed privatemaker closed 5 years ago

privatemaker commented 5 years ago

When requesting from /api/v2/personal/token-token/daily/0-3 if there are no results for current day(s) the API return empty [ ] this does not allow Reality Check to show anything to a user. tracking-exposed/facebook.tracking.exposed#16

Better solution: return most recent 3 days. Kind of relates to #143

vecna commented 5 years ago

This has been implemented in a way:

at every hour a batch script counts the activity of the last active users
this imply, if an user create a profile at 4:20, they should have to wait until 5:00 until get some measurement
now with easy and with small amount of data, can be returned one object for every day of activity.
this afternoon is it still unstable, I'm counting numbers from the past days

vecna commented 5 years ago

fully completed. please check

privatemaker commented 5 years ago

this seems good now and is fixed. thnx