search

tracking-exposed / trex

youtube & tiktok analysis + youchoose recommendation custmizer. backend, extensions, and tooling
https://docs.tracking.exposed
GNU Affero General Public License v3.0
52 stars 15 forks source link

chore(workspace): pre-push hook #815

Closed ascariandrea closed 1 year ago

ascariandrea commented 1 year ago

This hook enforces to run yarn build (commented out at the moment cause docs aren't building) and yarn test before pushing, adding ~6 min to the time needed for push

With this in place we should have a better flow to be sure we're not pushing "wrong code", but it can be easily disable with -n at any occurrence

ascariandrea commented 1 year ago

Yep, I can move the logic inside the shared package, will do 👍🏽

ascariandrea commented 1 year ago

@rekoke I merged the scripts into one!

ascariandrea commented 1 year ago

I also removed the yarn build step and the --runInBand option from jest that runs tests sequentially. With this configuration we're only adding +70/80 seconds on git push, which I think is an acceptable tradeoff.

vecna commented 1 year ago

Sorry I realized now, to accept this PR we need to consider docker as requisite for development; I didn't see explicit

ascariandrea commented 1 year ago

@vecna I added docker as requirement in the README.md