search

tractorcow-farm / silverstripe-fluent

Multi-language translate module for Silverstripe, without having to manage separate site trees.
BSD 3-Clause "New" or "Revised" License
93 stars 111 forks source link

DEP Limit PHP support for CMS 6 #874

Closed GuySartorelli closed 3 months ago

GuySartorelli commented 3 months ago

Issue

tractorcow commented 3 months ago

PHP 8.3 has a bunch of linting errors when using self:: in extensions. Do you want to address those in this same PR?

GuySartorelli commented 3 months ago

The linting errors aren't related to PHP 8.3. They have been addressed on the 7 branch in https://github.com/tractorcow-farm/silverstripe-fluent/pull/867 - that just needs to be merged up for phplinting to be happy so that will be dealt with separately.

The trailing slash failures have also already been dealt with (in https://github.com/tractorcow-farm/silverstripe-fluent/pull/872) and that just needs to be merged up.

I'll merge those up soon and rebase this PR on top of it, so we can see if there are any remaining CI failures to deal with.

tractorcow commented 3 months ago

Sounds good, go ahead and do those merges as you see fit.

GuySartorelli commented 3 months ago

Tried to push a merge up to the 7 branch and got an error "Changes must be made through a pull request". So I've raised https://github.com/tractorcow-farm/silverstripe-fluent/pull/877

After that's merged I'll need to do another one merging 7 up to 8.

tractorcow commented 3 months ago

7 has been merged.

GuySartorelli commented 3 months ago

Thanks! I've created https://github.com/tractorcow-farm/silverstripe-fluent/pull/878 merging 7 to 8.

tractorcow commented 3 months ago

I've left that PR approved; you can merge when ready friend.

GuySartorelli commented 3 months ago

Merged that, and rebased this on top. And it's green! 🎉