replace declarative-option with trailblazer-option - Githubissues

trailblazer / cells

View components for Ruby and Rails.

https://trailblazer.to/2.1/docs/cells.html

3.06k stars 236 forks source link

replace declarative-option with trailblazer-option #511

Open rocket-turtle opened 1 week ago

rocket-turtle commented 1 week ago

Currently declarative-option and trailblazer-option get installed.

There was already a merge for this: https://github.com/trailblazer/cells/pull/492/files But I think the changes got lost with the force push in https://github.com/trailblazer/cells/pull/509 https://github.com/trailblazer/cells/compare/b5ceeaaa295cdc2094003679148e996fb52b6c73..573c411daa00ed41293824123b839949660b5daf

Was that intentional? Do you plan to replace declarative-option?

cells 4.1.8

updated to declarative-builder ~> 0.2.0
- which changed from declarative-option < 0.2.0 to trailblazer-option ~> 0.1.0
- https://github.com/apotonick/declarative-builder/commit/097c11f75311191ca3654ce24e688ca73f1dba02
cells still depends on declarative-option < 0.2.0

AlfonsoUceda commented 4 days ago

Hey @rocket-turtle sorry for the problem!

I created this PR, cold you check it? https://github.com/trailblazer/cells/pull/512

rocket-turtle commented 3 days ago

Thank you. Looks good to me. I get no error with our codebase.