search

trailofbits / cb-multios

DARPA Challenges Sets for Linux, Windows, and macOS
https://blog.trailofbits.com/2016/08/01/your-tool-works-better-than-mine-prove-it/
MIT License
520 stars 103 forks source link

Undefined behaviors and minor syntactic issues #57

Open maroneze opened 5 years ago

maroneze commented 5 years ago

While using the challenges as part of NIST's SATE 6 tool evaluation, Frama-C identified some issues in a few challenges, mostly related to undefined behaviors (e.g. shift of negative values, read of uninitialized variables), but also a few typos, which do not correspond to the intended bugs in the challenges, indicating they seem to be accidental.

I compiled a partial report of the issues and reported them to NIST, which suggested to report them upstream.

Would you be interested in patches for them? If there is interest, I can submit pull requests to each item separately, so you can decide whether to take it into consideration. For instance, some programmers don't care about signed overflows, so you may decide not to merge those.

dguido commented 5 years ago

Yes please! That would be wonderful. Thanks.