Closed arcz closed 3 years ago
While I haven't tested this yet, I think we might need to add something like a
find_package(GTest CONFIG REQUIRED)
whenUSE_SYSTEM_GTEST
isON
, and then this line will probably also need a conditional onUSE_SYSTEM_GTEST
Yeah, I was confused as to how Nix was picking up the GTest build correctly without that. @arcz any thoughts?
(FWIW, the build failures are probably unrelated. I'll look into them in a moment.)
Install/Update ports
Running 'vcpkg remove --outdated --recurse ' in directory '/Users/runner/work/uthenticode/uthenticode/vcpkg' ...
dyld: Symbol not found: ___emutls_v._ZSt11__once_call
🤔
https://github.com/lukka/run-vcpkg/issues/69 has the problem.
Edit: And #41 should have the fix in a moment.
Just something to note: the reason uthenticode didn't use a system copy of GTest is because GTest's authors recommend vendoring it as part of each build (presumably to avoid ABI issues).
That shouldn't be a problem with Nix, but we probably don't want to encourage people to use an arbitrary system build of GTest (e.g., the version distributed as googletest
by Ubuntu).
While I haven't tested this yet, I think we might need to add something like a find_package(GTest CONFIG REQUIRED) when USE_SYSTEM_GTEST is ON, and then this line will probably also need a conditional on USE_SYSTEM_GTEST
Yep, this currently works magically on Nix because Nix adds the GTest include and link directories on its own. IMO that's actually probably how we want things for now, since we don't want to encourage people to use arbitrary system distributions of GTest (per above).
This allows to use already built gtest by supplying a cmake flag. Doesn't change the current build.