search

trailofbits / uthenticode

A cross-platform library for verifying Authenticode signatures
https://trailofbits.github.io/uthenticode/
MIT License
136 stars 33 forks source link

Fix: find GTest when USE_EXTERNAL_GTEST #43

Closed ekilmer closed 3 years ago

ekilmer commented 3 years ago

This only works on some of the latest releases of googletest, since previously the name passed to find_package was different.

Adding this is still better than not, since previously it will always fail if trying to compile tests with -DUSE_EXTERNAL_GTEST=ON

Renames USE_SYSTEM_GTEST to USE_EXTERNAL_GTEST, since GTest could come from anywhere, not necessarily system-installed location.

Improves upon #40

ekilmer commented 3 years ago

Closing after reading this comment more thoroughly.

[...] we don't want to encourage people to use arbitrary system distributions of GTest [...]

ekilmer commented 3 years ago

Reopening after internal discussion of packaging use cases. Added a warning message about use of the option.