search

trailofbits / uthenticode

A cross-platform library for verifying Authenticode signatures
https://trailofbits.github.io/uthenticode/
MIT License
136 stars 33 forks source link

Adapt pe-parse include path, remove legacy CMake target name #47

Closed chausner closed 2 years ago

chausner commented 2 years ago

The latest versions of pe-parse use the include path pe-parse instead of parser-library. This project claims to be compatible to the latest pe-parse but is still using the old include path. This fixes it.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

woodruffw commented 2 years ago

The latest versions of pe-parse use the include path pe-parse instead of parser-library. This project claims to be compatible to the latest pe-parse but is still using the old include path. This fixes it.

This was actually held back on an update to vcpkg's version of pe-parse, but someone might have gotten to it. I'll run the CI and we'll find out...

chausner commented 2 years ago

I have a PR pending updating it to the latest version: https://github.com/microsoft/vcpkg/pull/20918

woodruffw commented 2 years ago

Fantastic, thanks! We'll wait for that to get merged and then bump the CI to accommodate the vcpkg update.

woodruffw commented 2 years ago

I'm going to roll this up into #51. Will mark you as a coauthor on it, so it preserves your contribution. Thanks again!