search

trainline-eu / stations

List of stations and associated metadata
Open Data Commons Open Database License v1.0
104 stars 129 forks source link

Disable 165 obsolete SNCF stations #1311

Closed anaalta closed 5 months ago

anaalta commented 5 months ago

PAO decommissioned some city codes in May. Since then, when we send the old SNCF codes we get an unknown locality error. Since we did not get a changelog, we needed to analyse the changes and their impact ourselves. We identified the following situations:

  1. new SNCF stations -> list of UIC (51) that are not enabled for SNCF in our master file and that exist in the new SNCF file. May have some station that we do not have in our master file.
  2. same UIC but CODE CHANGED. -> list of UIC (20) that have their code changed between the old and new SNCF files. -> should be updated in our master file.
  3. Obsolete SNCF stations-> list of UIC (166) that do not exist anymore in the new SNCF file.

File with changes: Bordeaux .xlsx

ConscritNeuneu commented 5 months ago

You'll have to be careful with this one, as it was just fixed earlier to have as a parent Genève instead of Genève, Cornavin. Genève Champel

ConscritNeuneu commented 5 months ago

Also I believe that we should rather delete obviously obsolete stations rather than make them just non suggestable (that is if there are no active products using them).

anaalta commented 5 months ago

Ah! It was never my intention, I need to rebase, thanks for the heads up!

You'll have to be careful with this one, as it was just fixed earlier to have as a parent Genève instead of Genève, Cornavin. Genève Champel

ConscritNeuneu commented 5 months ago

You still have test failures

anaalta commented 5 months ago

I will close this PR and split it in more manageable parts.