Closed aornugent closed 2 years ago
:exclamation: No coverage uploaded for pull request base (
develop@27e391c
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #339 +/- ##
==========================================
Coverage ? 79.63%
==========================================
Files ? 97
Lines ? 8897
Branches ? 0
==========================================
Hits ? 7085
Misses ? 1812
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 27e391c...c29a177. Read the comment docs.
Merged and extended in simple_water_model
branch.
Draft of changes to modularise how assimilation is calculated. Where previously the per-leaf photosynthetic canopy was hard-coded, it now resides in
FF16_Strategy::compute_assimilation
which is passed toassimilation::assimilate
for integration along the distribution of canopy openness during calculation ofnet_mass_production_dt
.I've left the leaf level approximation in
assimilation
for now, which can be accessed from theassimilator
object -When FF16w comes online, we can substitute in a new method while also reusing
q
to access information about the distribution of leaf area -The only requirements are to return a double and scale the result by
area_leaf
:We can modify this last line if additional scaling terms are needed and set them to 1 in FF16 to maintain backwards compatibility.