search

tramarobin / fctSnPM

Using spm1d package (v.0.4.3), compute anova and post-hoc tests from anova1 to anova3rm, with a non-parametric approach (permutation tests)
GNU General Public License v3.0
2 stars 2 forks source link

[JOSS Review] Suggestion: spm1d dependency #7

Closed 0todd0000 closed 3 years ago

0todd0000 commented 3 years ago

Please consider removing spm1d_Pataky from the repository, and instead listing it as a third-party requirement of this package.

The spm1d source code gets updated periodically with additional features and bug fixes, and the easiest way to propagate those changes to fctSPM would probably be to update fctSPM-specific code as needed, rather than manually update spm1d_Pataky.

If you choose to keep spm1d_Pataky in this repository, please note in the manuscript that spm1d_Pataky is published elsewhere, and thus is not part of this JOSS review.

tramarobin commented 3 years ago

I think it would be easier to let the pacage inside the repository. I modified the manuscript accordingly (lines 34-36) : updated Manuscript.pdf

0todd0000 commented 3 years ago

OK. Please change: "integrated in the fctSPM repository" to "redistributed with fctSPM".

(No customizations appear to have been applied to the spm1d source code, so I think "redistributed" is more appropriate than "integrated".)

tramarobin commented 3 years ago

This has been changed in the article. Indeed, no modification of the spm1d package has been made.

0todd0000 commented 3 years ago

OK, thank you.