tramlinehq / tramline

Release coordination and deployment platform, just for your mobile apps
https://tramline.app
Apache License 2.0
237 stars 12 forks source link

Migrate all ActiveJobs to Sidekiq jobs #690

Open kitallis opened 4 days ago

kitallis commented 4 days ago

Context

This is a pure technical debt requirement. All our background jobs are run through the sidekiq adaptor. But many of the jobs do not inherit from ActiveJob, but instead just call include Sidekiq::Job.

Sidekiq jobs have a lot more control and testing ease than active job counterparts, in general. So we should move them all to be consistent, and actually move to include Sidekiq::Job instead.

Requirements & acceptance criteria

Move all jobs to include Sidekiq::Job. Do this by changing ApplicationJob to simply include it and have all jobs inherit from ApplicationJob.

This would broadly require:

Additional notes

This will also allow us to add more details for sentry exceptions, because we can write Sidekiq middlewares to do that.

gitstart-connector[bot] commented 4 days ago

Issue synced into GitStart. Please review, edit and hand it off to GitStart by following this link.

gitstart-connector[bot] commented 4 days ago

This issue has been handed off to GitStart: https://clients.gitstart.com/tramline/11653/tickets/TRAB-690