search

transientskp / banana

a web interface for the Transient Pipeline database
http://docs.transientskp.org/
Other
4 stars 6 forks source link

show forcedfits_count #102

Closed gijzelaerr closed 8 years ago

gijzelaerr commented 9 years ago

Show the number of forced fits since the last blind fit for an runningcatalog

related tkp issue: https://github.com/transientskp/tkp/pull/472

timstaley commented 8 years ago

whoa... new git-fu http://stackoverflow.com/questions/2945344/how-do-i-select-a-merge-strategy-for-a-git-rebase ... (I rebased this and checked the merge / rebased copies were identical ).

timstaley commented 8 years ago

Hmm - just tried this out and it doesn't seem to always give the correct result, so let's not merge it just yet. Works for another dataset, just not this one. Screenshot below. screenshot - 161215 - 18 10 16

gijzelaerr commented 8 years ago

hm... This is a problem in TraP then, not banana. the forcedfits_count value is not incremented properly.

timstaley commented 8 years ago

OK, I'll take a look at the dataset and see if I can figure out what's borked.

gijzelaerr commented 8 years ago

I think Bart once implemented this as a optimisation, but I think we can also just do this with a count(extract_type) where extract_type=1

gijzelaerr commented 8 years ago

@timstaley shall we just merge this? then I make a 3.0rc for banana also.

timstaley commented 8 years ago

Hmm. I guess... I would prefer to track down the root cause of the bug first, but that won't happen for some time probably.