search

transientskp / banana

a web interface for the Transient Pipeline database
http://docs.transientskp.org/
Other
4 stars 6 forks source link

Blind/forced extracted sources information #98

Closed ajstewart closed 9 years ago

ajstewart commented 9 years ago

I've made some edits to basically solve my issues in #60. The number of blind and forced extractions is now stated on the image list and detail pages (see example images).

There may be a better way to do this rather than the way I've done, if so I'd be interested to know and feel free to ignore this (I wasn't sure how to mimic 'image.num_extractedsources'). I'm also wondering whether the forced fits column on the image list page is needed, as you can see the difference between the total and blind extracted sources, but maybe it's nice to have it there anyway.

Only thing not addressed is the plot on the dataset overview page. Though I'm not sure what others think on whether this should be changed or not. I think it's minor in any case and I'm happy with this information above now available.

imagelist_newcols

imagedetail_newinfo

gijzelaerr commented 9 years ago

well done! Do you know how to squash commits into one?

ajstewart commented 9 years ago

Ah that's useful, I'll look up how to squash them. Would I then create a new pull request?

gijzelaerr commented 9 years ago

no you can force push to your branch. be careful not to destroy your branch though. you can make a backup branch just to be sure.

ajstewart commented 9 years ago

You were right with the sorting. I figured out how the num_extractedsources works and mimicked it in the lists.py and did some crude filtering on the annotation. It seems to work ok.

gijzelaerr commented 9 years ago

last comment, the merged PR#1 is not so pretty. It is better to just try to rebase the master on your branch.