Closed PeterDaveHello closed 1 year ago
The CI failed on markdown-link-check because of this bug: https://github.com/tcort/markdown-link-check/issues/254
Both markdown-link-check v3.11.0 & v3.11.1 got this problem:
$ find . -type f -name "*.md" | xargs -n 1 markdown-link-check
/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:99
input.opts.config = program.opts().config.trim();
^
TypeError: Cannot read properties of undefined (reading 'trim')
at getInputs (/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:99:44)
at main (/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:232:20)
/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:99
input.opts.config = program.opts().config.trim();
^
TypeError: Cannot read properties of undefined (reading 'trim')
at getInputs (/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:99:44)
at main (/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:232:20)
markdown-link-check v3.10 works without problem though:
$ find . -type f -name "*.md" | xargs -n 1 markdown-link-check
FILE: ./ISSUE_TEMPLATE.md
No hyperlinks found!
0 links checked.
FILE: ./README.md
[✓] https://app.travis-ci.com/transmission-remote-gui/transgui
[✓] #introduction
[✓] #installation
[✓] #linux
[✓] #easy-way-recommended
[✓] #harder-way
[✓] #windows
[✓] #portable-zip-tarball-recommended
[✓] #installer
[✓] #using-chocolatey
[✓] #macos
[✓] #without-a-package-manager
[✓] #homebrew
[✓] #command-line-parameters
[✓] #portable-mode
[✓] #fixed-hotkeys
[✓] #advanced-parameters
[✓] #license
[✓] https://github.com/transmission-remote-gui/transgui/releases/latest
[✓] https://www.microsoft.com/download/details.aspx?id=40784
[✓] http://download.microsoft.com/download/0/5/6/056dcda9-d667-4e27-8001-8a0c6971d6b1/vcredist_x86.exe
[✓] https://wiki.openssl.org/index.php/Binaries
[✓] https://slproweb.com/products/Win32OpenSSL.html
[✓] https://chocolatey.org
[✓] https://brew.sh/
[✓] https://github.com/transmission-remote-gui/transgui/issues/924
[✓] https://github.com/transmission-remote-gui/transgui/issues/1020
[✓] https://github.com/transmission-remote-gui/transgui/issues/1070
[✓] https://app.travis-ci.com/transmission-remote-gui/transgui.svg?branch=master
[✓] http://i.imgur.com/XBbF4Vh.png
30 links checked.
Node.js v10 is EoL-ed for a while (since 2021-04-30), would be great to update to the a newer LTS version.
As node.js v18 prebuilt binary needs newer build environment, otherwise will receive the following error:
So just update to v16 first, and update to a new version later, after the build environment on Travis CI also updated to a new version.
Reference: https://github.com/nodejs/Release