transmission-remote-gui / transgui

🧲 A feature rich cross platform Transmission BitTorrent client. Faster and has more functionality than the built-in web GUI.
GNU General Public License v2.0
3.23k stars 280 forks source link

Update node.js on Travis CI from dated v10 to v16 #1451

Closed PeterDaveHello closed 1 year ago

PeterDaveHello commented 1 year ago

Node.js v10 is EoL-ed for a while (since 2021-04-30), would be great to update to the a newer LTS version.

As node.js v18 prebuilt binary needs newer build environment, otherwise will receive the following error:

node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)

So just update to v16 first, and update to a new version later, after the build environment on Travis CI also updated to a new version.

Reference: https://github.com/nodejs/Release

what-the-diff[bot] commented 1 year ago

PR Summary

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/transmission-remote-gui/transgui/1451/d8ac1132/515caf51cc915008dc7524a8077c47b371e4535f.svg)](https://app.codesee.io/r/reviews?pr=1451&src=https%3A%2F%2Fgithub.com%2Ftransmission-remote-gui%2Ftransgui) #### Legend CodeSee Map legend
PeterDaveHello commented 1 year ago

The CI failed on markdown-link-check because of this bug: https://github.com/tcort/markdown-link-check/issues/254

PeterDaveHello commented 1 year ago

Both markdown-link-check v3.11.0 & v3.11.1 got this problem:

$ find . -type f -name "*.md" | xargs -n 1 markdown-link-check
/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:99
                input.opts.config = program.opts().config.trim();
                                                         ^

TypeError: Cannot read properties of undefined (reading 'trim')
    at getInputs (/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:99:44)
    at main (/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:232:20)
/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:99
                input.opts.config = program.opts().config.trim();
                                                         ^

TypeError: Cannot read properties of undefined (reading 'trim')
    at getInputs (/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:99:44)
    at main (/home/peter/.nvm/versions/node/v16.20.0/lib/node_modules/markdown-link-check/markdown-link-check:232:20)

markdown-link-check v3.10 works without problem though:

$ find . -type f -name "*.md" | xargs -n 1 markdown-link-check                                                                                                 

FILE: ./ISSUE_TEMPLATE.md
  No hyperlinks found!                                                         

  0 links checked.                                                                                                                                            

FILE: ./README.md                                                              
  [✓] https://app.travis-ci.com/transmission-remote-gui/transgui               
  [✓] #introduction
  [✓] #installation                                                            
  [✓] #linux                                                                                                                                                  
  [✓] #easy-way-recommended                                                                                                                                   
  [✓] #harder-way                                                                                                                                             
  [✓] #windows                                                                 
  [✓] #portable-zip-tarball-recommended
  [✓] #installer
  [✓] #using-chocolatey                                                        
  [✓] #macos                                                                   
  [✓] #without-a-package-manager                                                                                                                              
  [✓] #homebrew                                                                
  [✓] #command-line-parameters                                                 
  [✓] #portable-mode        
  [✓] #fixed-hotkeys  
  [✓] #advanced-parameters                                                     
  [✓] #license                                                                 
  [✓] https://github.com/transmission-remote-gui/transgui/releases/latest
  [✓] https://www.microsoft.com/download/details.aspx?id=40784                                                                                                
  [✓] http://download.microsoft.com/download/0/5/6/056dcda9-d667-4e27-8001-8a0c6971d6b1/vcredist_x86.exe                                                                                      
  [✓] https://wiki.openssl.org/index.php/Binaries                                              
  [✓] https://slproweb.com/products/Win32OpenSSL.html                                          
  [✓] https://chocolatey.org                                                                                                                                  
  [✓] https://brew.sh/                                                                                                                                        
  [✓] https://github.com/transmission-remote-gui/transgui/issues/924                           
  [✓] https://github.com/transmission-remote-gui/transgui/issues/1020                          
  [✓] https://github.com/transmission-remote-gui/transgui/issues/1070                          
  [✓] https://app.travis-ci.com/transmission-remote-gui/transgui.svg?branch=master                                                                                                            
  [✓] http://i.imgur.com/XBbF4Vh.png           

  30 links checked.