transport-data / tdc-data-portal

https://tdc-data-portal.vercel.app
1 stars 1 forks source link

[improvement] Enhance Pagination Experience on Newsfeed Page #182

Open Uchechukwu-Onye-Igbo opened 3 weeks ago

Uchechukwu-Onye-Igbo commented 3 weeks ago

When browsing the newsfeed on the TDC portal, I want a smooth and responsive pagination experience, so that I can easily navigate through updates without lag or confusion and focus on the content.

Tasklist (TBD - updated by the developer)

Acceptance Criteria

Given that I am navigating content on the newsfeed page,

Uchechukwu-Onye-Igbo commented 2 weeks ago

Hello @Gutts-n if you have reviewed this implementation, kindly update it to the right status. thank you

Gutts-n commented 2 weeks ago

@willy1989cv

cc: @Uchechukwu-Onye-Igbo

nicolas-becker commented 1 week ago

I was pointed here by @willy1989cv to flag the following issue:

The username of the user whose permission rights were changed is not displayed in the notification: image

Uchechukwu-Onye-Igbo commented 1 week ago

I was pointed here by @willy1989cv to flag the following issue:

The username of the user whose permission rights were changed is not displayed in the notification: image

hello @Gutts-n please take a look at this comment

Gutts-n commented 1 week ago

@nicolas-becker which of the notifications on the print should present the user that you changed? And how can I reproduce this notification on my newsfeed tab?

Gutts-n commented 1 week ago

Documentation: https://github.com/transport-data/tdc-data-portal/blob/main/docs/newsfeed/README.md

nicolas-becker commented 1 week ago

@nicolas-becker which of the notifications on the print should present the user that you changed? And how can I reproduce this notification on my newsfeed tab?

@Gutts-n The notifcation "You updated the user" should contain at least the name of the user. So in this case "You updated the user vvilly89". Better would be of course if the notification contained the full information that I updated the user from member to editor for organizationX.

You should be able te reproduce the error if you change a member's permission rights for an organization you are admin of.

Uchechukwu-Onye-Igbo commented 1 week ago

@nicolas-becker which of the notifications on the print should present the user that you changed? And how can I reproduce this notification on my newsfeed tab?

@Gutts-n The notifcation "You updated the user" should contain at least the name of the user. So in this case "You updated the user vvilly89". Better would be of course if the notification contained the full information that I updated the user from member to editor for organizationX.

You should be able te reproduce the error if you change a member's permission rights for an organization you are admin of.

hello @Gutts-n please take a look at this comment

Gutts-n commented 1 week ago

@Uchechukwu-Onye-Igbo, I think @willy1989cv is looking at it. We agreed via chat some days ago that he would fix this.

@willy1989cv if you aren't looking, please let me know.

willy1989cv commented 1 week ago

@Gutts-n yes, I am looking at it right now

willy1989cv commented 4 days ago

Fixed. Image

nicolas-becker commented 1 day ago

Hi @willy1989cv , the pagination itself is working fine, but I am not sure about this: https://github.com/transport-data/tdc-data-portal/issues/182#issuecomment-2483021369

Just to be sure, that I am testing the right thing: This notification appears when a user permission level is updated, right? It should appear both to the user and to the admin who has changed the permission level.