search

travis-ci / dpl

Dpl (dee-pee-ell) is a deploy tool made for continuous deployment.
MIT License
1.29k stars 367 forks source link

Update CloudFoundry CLI to v7 #1211

Closed abdonrd closed 4 years ago

abdonrd commented 4 years ago

Official instructions:

https://github.com/cloudfoundry/cli/blob/master/doc/installation-instructions/installation-instructions-v7.md#installers-and-compressed-binaries

Also adding support to the new CLI v7 has a new strategy option for rolling deploy: https://docs.cloudfoundry.org/devguide/deploy-apps/rolling-deploy.html

Fix #910

BanzaiMan commented 4 years ago

Specs need fixing.

abdonrd commented 4 years ago

@BanzaiMan it should works now! 😁

BanzaiMan commented 4 years ago

Great. Now, could you test this code to deploy your app?

abdonrd commented 4 years ago

@BanzaiMan ok! How can I test it?

BanzaiMan commented 4 years ago

It's explained in https://github.com/travis-ci/dpl#testing-dpl-branches-or-forks-on-travis-ci

abdonrd commented 4 years ago

@BanzaiMan yay! It's working!

https://travis.ibm.com/ETX/rendertron/builds/37482611

Screenshot 2020-09-02 at 17 51 29 Screenshot 2020-09-02 at 17 51 00
abdonrd commented 4 years ago

@BanzaiMan thanks! Now do you need to create a new release? Or should it start working in production directly?

abdonrd commented 4 years ago

Friendly ping to @BanzaiMan. 😄

Tansito commented 4 years ago

Interested on this too! 👀

abdonrd commented 4 years ago

@BanzaiMan @eugene-travis when we can start to use this? Thanks in advance!

BanzaiMan commented 4 years ago

This should be available in the --pre release.

https://github.com/travis-ci/dpl/blob/v2.0.2.beta.1/lib/dpl/providers/cloudfoundry.rb#L25

abdonrd commented 4 years ago

Thanks @BanzaiMan!

To use the --pre I need to setup the edge: true, right?

Because with this:

Screenshot 2020-10-15 at 18 06 12

Now the provider doesn't work:

Screenshot 2020-10-15 at 18 06 38
BanzaiMan commented 4 years ago

hpc is not a string that should happen in normal processing. I tend to think that you have an incorrect value in $IBMCLOUD_API_KEY that leads to this invocation.

abdonrd commented 4 years ago

@BanzaiMan mmm but this deploy is working just without these changes:

Screenshot 2020-10-15 at 18 06 12
BanzaiMan commented 4 years ago

Hmmm. That is bizarre. Earlier, in https://github.com/travis-ci/dpl/pull/1211#issuecomment-685828183 you indicated that the code was working. :-( I am not quite sure what's happening.

abdonrd commented 4 years ago

@BanzaiMan yes, that's why I don't understand what is happening 😕

abdonrd commented 4 years ago

@BanzaiMan proposal: https://github.com/travis-ci/dpl/pull/1219