search

travitch / persistent-vector

Persistent vectors for Haskell based on array mapped tries
BSD 3-Clause "New" or "Revised" License
27 stars 4 forks source link

Unsliced #8

Closed treeowl closed 3 years ago

treeowl commented 3 years ago

Unsliced vectors. I basically applied or reproduced the effects of) most of the commits following the addition of slicing, but without slicing. I still need to do my type-splitting commit. While I was at it, I made some improvements for performance purposes.

treeowl commented 3 years ago

Some more low-hanging fruit: We should never do Array.fromList n . reverse. Rather, we should write a function that builds an array from a list backwards and use that. That way we won't have to allocate a reversed list we'll never need again.

Done

travitch commented 3 years ago

What happened to the history? Did you go back and replay the history somehow? I'll take a look at squashing this tomorrow

treeowl commented 3 years ago

Preserving the history while working seemed too hard, so I just based off an old commit. We can eventually squash all my stuff and rebase on master. Or whatever. I'm not so good with this git stuff.

treeowl commented 3 years ago

I'm working through rebasing this now. Bleh!

treeowl commented 3 years ago

Closing in favor of #17.