trek-view / gopro2gsv

Processes .jpg images and .mp4/.360 videos shot on GoPro MAX or Fusion cameras and uploads to Google Street View.

Apache License 2.0

4 stars 0 forks source link

validation for mode 1 are not being checked #37

Closed himynamesdave closed 9 months ago

himynamesdave commented 9 months ago

29

python3 gopro2gsv.py \
    --input_video tests/hero_videos/GH018678.MP4 \
    --path_to_nadir stock_nadirs/without_gopro/trek_view_full_nadir.png \
    --output_filepath tests/output/test0/GH018678.MP4

To try and make this easier for the script we should also add a flag where user sets mode at input

--mode = https://github.com/trek-view/gopro2gsv/tree/max-dev#gopro2gsv

https://github.com/trek-view/gopro2gsv/blob/max-dev/design/mvp/modes-specification.md

fqrious commented 9 months ago

I don't think mode is needed