Closed himynamesdave closed 9 months ago
@fqrious still happens. Can you point me to the bit of code that generated so I can see logic?
(gopro2gsv-venv) dgreenwood@Davids-MBP-2 gopro2gsv % python3 gopro2gsv.py \
--input_video tests/ski/GS016843.mp4 \
--path_to_nadir stock_nadirs/without_gopro/trek_view_full_nadir.png \
--output_filepath tests/output/mode1/test1/GS016843.mp4
30-Nov-23 07:15:22 [GoPro2GSV] [INFO] ====================================================
30-Nov-23 07:15:22 [GoPro2GSV] [INFO] =====================GoPro2GSV======================
30-Nov-23 07:15:22 [GoPro2GSV] [INFO] ====================================================
30-Nov-23 07:15:22 [GoPro2GSV] [INFO] Saving log to `/Users/dgreenwood/Documents/repos/trek-view/gopro2gsv/tests/output/mode1/test1/GS016843.log`
30-Nov-23 07:15:22 [GoPro2GSV] [INFO] =====================GoPro2GSV======================
30-Nov-23 07:15:24 [GoPro2GSV] [INFO] Found 5376x2688 video with 23 valid GPS points at tests/ski/GS016843.mp4
30-Nov-23 07:15:24 [GoPro2GSV] [INFO] Post-processing video #1 of 1
30-Nov-23 07:15:24 [GoPro2GSV] [INFO] Adding nadir to video
It counts Gpsdatetime which is usually less points than lat/long/alt. For every gps time, there's usually an extra 5-10 lat/long pairs. In the original implementation, you told me to count GPSTimeStamp. I can change this to count GpsLatitude instead though
@fqrious yes, could you please count GpsLongitude instead?
I input
GS016843.mp4 = 00:03:07 (187 secs) duration
But the logs show
23 valid frames
This should actually read GPS points. It should also read how many valid points there are (there are definitely more then 23, so I think this is a bug)