search

trevorld / r-ledger

Imports data from plain text accounting files
Other
39 stars 2 forks source link

import transaction comments from ledger #16

Closed esovetkin closed 6 years ago

esovetkin commented 6 years ago

the changes simply rename 'V8' column to 'comment', and allow this column to be selected.

codecov-io commented 6 years ago

Codecov Report

Merging #16 into master will increase coverage by 1.31%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   93.42%   94.73%   +1.31%     
==========================================
  Files           2        2              
  Lines         152      152              
==========================================
+ Hits          142      144       +2     
+ Misses         10        8       -2
Impacted Files Coverage Δ
R/register.r 93.75% <100%> (+1.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87c257a...8721a1b. Read the comment docs.

trevorld commented 6 years ago

Jenya, thanks for the PR!

Do you happen to know what the second column (V2) is supposed to contain? It and the comment field (V8) were always all missing values for the test ledger files I read in and the ledger csv output lacks a header.

esovetkin commented 6 years ago

the V2 column is also a mystery to me...