trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
241 stars 146 forks source link

Required go version #283

Closed etam closed 1 year ago

etam commented 1 year ago

README.md says that "trezord-go requires go >= 1.12". But at https://github.com/trezor/trezord-go/blob/v2.0.32/trezord.go#L105 BuildInfo.Settings is used, which according to documentation (https://pkg.go.dev/runtime/debug#BuildSetting) was added in go 1.18.

prusnak commented 1 year ago

The whole sentence reads trezord-go requires go >= 1.12, but 1.18 is recommended for git version stamping (and for better speed in general)

Are you implying the code above does not build on Go 1.17 or older?

etam commented 1 year ago

with go 1.16 I get this error:

./trezord.go:105:24: info.Settings undefined (type *debug.BuildInfo has no field or method Settings)
prusnak commented 1 year ago

I confirm I see the same error with Go 1.17.

Readme fixed in f559ee5079679aeb5f897c65318d3310f78223ca

Thanks!