search

trezor / trezord-go

:smiling_imp: Trezor Communication Daemon (written in Go)
GNU Lesser General Public License v3.0
241 stars 146 forks source link

On macOS 13.3 bridge shows 1 device as 2 devices #288

Closed matejkriz closed 1 year ago

matejkriz commented 1 year ago

Bridge 2.0.32 macOS 13.3.0/13.3.1

image (5)

Expected:

Actual:

detailed logs: log (1).gz

karelbilek commented 1 year ago

Based on the logs and the picture, the hidapi layer (that is there "just" for very very old devices) is somehow catching the new device

Can you try to merge this and send the log again? It seems there is no detailed logging for hidapi layer

289

karelbilek commented 1 year ago

the PR log might actually be leaking some private info so better not to actually merge it... just please send here the log that it produces

karelbilek commented 1 year ago

The bug will be somewhere there with the HID matching logic. But any fix would need to be re-tested with old HID devices on Mac and Windows to make sure it doesn't break something (not Linux, that is not using HIDAPI)

karelbilek commented 1 year ago

I think the easy fix would be to just remove the trezor2:=...; it doesn't use HID anyway. No idea why the new macos started showing it in the list now; maybe some combination of macos behaviour and hidapi code behaviour

matejkriz commented 1 year ago

new logs from https://github.com/trezor/trezord-go/pull/289/commits/73f1140b80e55696bbd4d23ea282598fd9f310ac log (5).gz

image

matejkriz commented 1 year ago

@trezor/qa please check PR description for notes for testing https://github.com/trezor/trezor-suite/pull/8100

bosomt commented 1 year ago

QA OK

tested and released to 23.4.2

Info: