search

trianglman / sqrl

PHP Server side implementation of a SQRL generator/listener
MIT License
98 stars 17 forks source link

Replaced vuk,suk with suk,vuk #19

Closed Ralle closed 5 years ago

Ralle commented 6 years ago

Still new to SQRL so I might be wrong. But from reading the code, this looks confusing.

https://github.com/trianglman/sqrl/blob/425d2f8b4ffd319408d6acf02a44b58a2531bafd/examples/server/includes/ExampleStatefulStorage.php#L69

    {
        $sql = "INSERT INTO sqrl_pubkey (public_key,vuk,suk) VALUES (?,?,?)";
        $stmt = $this->conn->prepare($sql);
        $stmt->execute(array($key,$suk,$vuk));
    }
rwese commented 5 years ago

@Ralle you are not wrong, it is confusing and there is actually an error in the order the arguments are bound.

public_key, vuk,       suk
$key,       $suk,      $vuk

other than that, the variable named could be more verbose but the function is only 4 lines so no biggy.

rwese commented 5 years ago

@Ralle can be closed now