search

trianglman / sqrl

PHP Server side implementation of a SQRL generator/listener
MIT License
98 stars 17 forks source link

Bring up to PSR0/1/2 compliance #8

Closed ghost closed 10 years ago

ghost commented 10 years ago

This PR brings the project into line with PSR0/1/2 and applies common conventions. I've added integration for Travis CI and added the package to packagist (https://packagist.org/packages/trianglman/sqrl) so the package can be installed using the name directly: this is how everyone does it.

I've also sped up output of the very slow CryptoTest.

Refs #7

ghost commented 10 years ago

@trianglman please can you also register at https://packagist.org/ - so I can add you to the maintainer list (and remove myself)

trianglman commented 10 years ago

The code is still in pre-alpha state. Once the SQRL spec has been finalized and Steve Gibson has created a reference implementation I will create a more stable branch and submit it to Packagist.

ghost commented 10 years ago

Composer is specifically designed to deal with code in all states, including alpha. Specifically dev, alpha, beta, stable. The code is untagged so it it's not even in alpha, just straight forward "in development".

This is how Composer is designed to be used. Upstream users can then select the stability they want. @alpha would not even be resolved if their code relied on a more stable version.

ghost commented 10 years ago

Here is the reference: http://getcomposer.org/doc/04-schema.md#minimum-stability means that upstream specifically has to request unstable code. But it does mean they can use Composer with packagist to get the package to work with if they need - regardless of SQRLs final status, upstream can still get on with prototyping/experimentation.