search

trilbymedia / grav-theme-bootstrap4

MIT License
14 stars 5 forks source link

Theme modernization question - deletion of metadata.html.twig? #10

Closed paulhibbitts closed 5 years ago

paulhibbitts commented 5 years ago

Thanks very much for adding deferred loading to this theme. I noticed that in this commit the filemetadata.html.twig was deleted yet it remains referenced in the base: https://github.com/trilbymedia/grav-theme-bootstrap4/blob/develop/templates/partials/base.html.twig#L8

Was this intentional?

Thanks very much, Paul

rhukster commented 5 years ago

Yes it’s been in core for some time.

paulhibbitts commented 5 years ago

Thanks for the quick clarification @rhukster , now I know to also remove it from my inherited Bootstrap4 Open Matter theme.

rhukster commented 5 years ago

I would recommend it removed from all themes unless you have a very specific change in there.

paulhibbitts commented 5 years ago

Thanks for the heads-up, will do.