search

trilinos / Trilinos

Primary repository for the Trilinos Project
https://trilinos.org/
Other
1.22k stars 570 forks source link

MueLu: Tutorial enabled even though I didn't ask for it #11782

Open bartgol opened 1 year ago

bartgol commented 1 year ago

Bug Report

I'm not sure this is really a bug, it might just be I'm missing a chain of cmake defaults that end up triggering this. And it may not be MueLu's fault, but an issue somewhere else, like tribits. But grepping the repo for ENABLE_Tutorial doesn't show anything outside of MueLu, so my first guess is MueLu.

Description

I am getting the following message at config time regarding MueLu tutorial:

...
Processing enabled top-level package: MueLu (Libs)
-- MueLu: Enabling deprecated code
-- MueLu's tutorial requires for a correct build that if Tpetra is enabled, then GlobalOrdinal=int must be enabled, and either the Serial or OpenMP Nodes in Tpetra be enabled.  Since this is not the case, I am disabling MueLu's tutorial by default.  See Trilinos GitHub Issue #1726 for details: https://github.com/trilinos/Trilinos/issues/1726
-- You chose to enable MueLu's tutorial, even though I told you that it may not build correctly.  You are responsible for whatever build or link errors may occur as a result.
-- MueLu: Enabling ETI support
...

I have not asked for MueLu's tutorial in my configure script. I only asked to enable MueLu. I also asked to disable tests and examples. I'm attaching the configure script in case any of the options I explicitly enabled/disabled may explain the behavior, though I doubt it. The cmake logic in MueLu's main CMakeList.txt related to this seems ok though, so I am a bit puzzled about this message (and intimidated by cmake scolding me).

This is a very low priority issue, I suppose. Although, the message mentions that we can't guarantee everything will link/build correctly. If link/build error could really occur,it would be quite annoying, especially considering that I never asked for the tutorial.

do-cmake.txt

@trilinos/muelu

GrahamBenHarper commented 1 year ago

@bartgol I think the message appears even when the tutorial does not build. Can you confirm whether your build directory has any binaries in packages/muelu/doc/Tutorial/src?

bartgol commented 1 year ago

@bartgol I think the message appears even when the tutorial does not build. Can you confirm whether your build directory has any binaries in packages/muelu/doc/Tutorial/src?

I don't have a Tutorial folder in the binary tree:

$ ls packages/muelu/doc/
CMakeFiles  cmake_install.cmake  CTestTestfile.cmake  Makefile  UsersGuide

Oh well, not a big deal.

GrahamBenHarper commented 1 year ago

No problem!

Also related, we're planning to merge #10633 in the next few weeks, which will modernize the tutorial and then we can delete that little bit of CMake logic that always checks GO=int for Epetra compatibility :)

mayrmt commented 1 year ago

Assigning @GrahamBenHarper and myself

github-actions[bot] commented 7 months ago

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label. If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE. If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

mayrmt commented 7 months ago

Once merged, #10633 will fix this.

/cc @GrahamBenHarper