search

trimble-oss / modus-web-components

This library provides Modus components as web components - reusable, encapsulated UI elements that are framework agnostic (can be implemented in any site).
https://modus-web-components.trimble.com/
MIT License
34 stars 71 forks source link

Table - Allow passing language as a parameter #3045

Open janwiebe-glasbergen opened 2 days ago

janwiebe-glasbergen commented 2 days ago

Prerequisites

Proposal

Add a language property to the modus-table that overrides the navigator.language.

Motivation and context

In our current applications we give the user the possibility to change the language using a query parameter. Currently we have to use a ugly hack to redefine the navigator.language property.

In my opinion navigator.language is okay as a fallback, but shouldn't be the only way to set the language of the components. As some applications require to switch the language on the fly.

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Low

What product/project are you using Modus Components for ?

Nova / Construction calculation platform UI

What is your team/division name ?

ACDC

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

No response

github-actions[bot] commented 2 days ago

Hello @janwiebe-glasbergen! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.