search

trinodb / charts

Apache License 2.0
151 stars 174 forks source link

Add coordinatorExtraNodeConfig and workerExtraNodeConfig #91

Closed soft-titus closed 3 months ago

soft-titus commented 1 year ago

This will be useful when we want to add different line in node.properties for coordinator and workers, for example :

server: coordinatorExtraNodeConfig: | node.id=trino-coordinator-XcaXd workerExtraNodeConfig: | node.id=${ENV:HOSTNAME}

Thanks.

cla-bot[bot] commented 1 year ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

nineinchnick commented 6 months ago

@soft-titus can you rebase this?

nineinchnick commented 3 months ago

This is a good suggestion, but this PR is abandoned, so I'm closing it.