search

trinodb / charts

Apache License 2.0
151 stars 174 forks source link

Add catalogsConfigmapOverride #92

Closed soft-titus closed 3 months ago

soft-titus commented 1 year ago

This to provide ability to use our own configmap for the catalogs instead of adding the catalogs inline in the values.yaml, for example :

catalogsConfigmapOverride: my-trino-catalog-configmap

Thanks.

cla-bot[bot] commented 1 year ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

nineinchnick commented 6 months ago

@soft-titus can you rebase, and configure it in https://github.com/trinodb/charts/blob/main/test-values.yaml, so we can see if it works?

nineinchnick commented 3 months ago

This is a good suggestion, but this PR is abandoned, so I'm closing it.