Fix for ChadoConnection::findVersion()

tripal / t4d8

This is a temporary repository for Drupal 9 upgrade for Tripal v4. It is meant to house issues related to the upgrade.

GNU General Public License v2.0

1 stars 10 forks source link

Fix for ChadoConnection::findVersion() #302

Closed laceysanderson closed 1 year ago

laceysanderson commented 1 year ago

This PR fixes the bug described in Issue #301.

Specifically,

Adds automated tests for the ChadoConnection::findVersion()
Adds the insert version command to the prepare SQL
Adds Tripalus databasica to the Chado Dummy SQL to allow a dummy chado to be built without error in tests
Some reformatting, added comments and small maintainability changes to the findVersion method.

risharde commented 1 year ago

@laceysanderson I just merged this into a branch of my GFF3 Unit Tests V2 which is still failing but thankfully now it isn't because of this bug - so I think this is working!!!

@spficklin @laceysanderson how quickly can we get this into master so I can pull this into my V2 unit testing?

laceysanderson commented 1 year ago

Hi @risharde, thanks for the confirmation! Hopefully ASAP. This branch has a test failing for the chado install form which isn't failing locally for me so I'm just checking into that right now but once tests are passing we should be good to go.

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit da1ef27f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 52.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 33.4% (0.1% change).

View more on Code Climate.