search

tripal / tripal_analysis_expression

Extension module for the Tripal toolset to show differential expression data. This module was made for Drupal 7, Tripal 3, and Chado 1.3.
GNU General Public License v2.0
4 stars 11 forks source link

Issue 405 extend Biosample Browser sep__biological_sample field to Project #406

Closed dsenalik closed 2 years ago

dsenalik commented 2 years ago

This pull request shows the changes used on carrotomics.org to display NCBI biosamples on project pages.

It extends the sep__biological_sample (Biosample Browser) to also be usable on Project content type.

A working example on the CarrotOmics site: https://carrotomics.org/bio_data/290817

I've been using these changes for close to a year, it's about time I submitted them!

spficklin commented 2 years ago

Hey @dsenalik . Thanks for the update. I'm going to merge it. It looks good.

However, after looking at your PR I noticed a major problem with this field (not your fault). It's not following proper coding standards. I'll merge this so that you can use it on your site, but the field does need to be corrected. I created an issue about it and what needs to be done to fix it: #407.