tripikad/trip2 - Githubissues

Installation

Start

It's recommended to use Laravel Valet for development. Follow its instructions. https://laravel.com/docs/master/valet

It's also recommended to install composer require global hirak/prestissimo first.

Then:

git clone https://github.com/tripikad/trip2
cd trip2
composer install
cp .env.example .env
php artisan key:generate
php artisan dusk:update --detect
yarn # or npm install
npm run dev

Databases

mysqladmin -uroot create trip
mysqladmin -uroot create trip2

Optionally use https://www.sequelpro.com or https://tableplus.com/ to set up the databases. Ask for access to staging server to get the latest trip2 database dump and migrate the data over, either using db client or run

mysql -uroot trip2 < dump.sql

Getting production images

In your .env file set the following parameter:

IMAGE_PATH=https://trip.ee/images/

Redis

To get production-level caching experience, install Redis using Homebrew and then add this to .env files:

CACHE_DRIVER=redis

Nginx cache

To test the local reverse proxy cache, edit /usr/local/etc/nginx/valet/valet.conf file:

Add the following to the top of the file:

fastcgi_cache_path /tmp/nginx levels=1:2 keys_zone=TRIP2:256m inactive=60m use_temp_path=off;
fastcgi_cache_key "$scheme$request_method$host$request_uri";

After the

fastcgi_param SCRIPT_FILENAME /.../

line add the following:

fastcgi_cache TRIP2;
fastcgi_ignore_headers Set-Cookie;
fastcgi_hide_header Set-Cookie;
fastcgi_pass_header Set-Cookie;
fastcgi_cache_bypass $cookie_logged $is_args;
fastcgi_no_cache $cookie_logged $is_args;
add_header X-Cache $upstream_cache_status;

and then run

valet restart

To clear the cache, run

rm -R /tmp/nginx/*
valet restart

Testing

Preparation

Make sure you use latest Chrome.
Run
```
php artisan dusk:update --detect
```
If you want to run Dusk tests with previous version of Chrome you will need specify a version of Dusk update. Read more here https://github.com/staudenmeir/dusk-updater
Make sure the FULL_BASE_URL in .env file points to the local Laravel URL of your development environment

Running all tests

npm run test

Running feature and browser tests separately

./vendor/bin/phpunit
php artisan dusk

Formatting code

To format the php, caa, js and vue files we use Prettier.

It is recommended to use VS Code Prettier plugin and set Format on Save setting to true.

To format all files in one go, run

npm run prettier

There is also a automatic task in Github to run npm run prettier on each pull request.

Frontend development

NPM commands

First make sure FULL_BASE_URL refers to local development URL.

npm run dev # runs watch + live
npm run watch # Unminified and fast dev build, recompiling on file change
npm run live # Live reload in browser
npm run devbuild # Unminified and fast dev build
npm run build # Minified and slow production build

Build process

The main entrypoint is ./resources/views/main.js what boots up a Vue instance and includes all the neccessary assets.

JS

Vue components from

./resources/views/components/**/*.vue

are compiled and minified to

./public/dist/main.hash.js

Lazy component loading

Vue components can also be lazy-loaded, most useful for components that have large dependecies.

<template>
    // ...
    <component :is="'Editor'" />
</template>
<script>
export default {
  components: {
    Editor: () =>
      import("../../components_lazy/Editor/Editor.vue")
  },
// ...

This creates an extra packages main.0.hash.js, main.1.hash.js etc which are loaded on demand via ajax when Editor component is on the page.

CSS

Components CSS from

./resources/views/components/**/*.css

and helper CSS from

./resources/views/styles/**/*.css

are concatted, processed using PostCSS (the configuration is at ./postcss.config.js) and saved to

./public/dist/main.hash.css

SVG

SVGs from ./resources/views/svg/**/*.svg

are concat into a SVG sprite, optimized, minified and saved to

./public/dist/main.svg

Frontend architecture: Components

API

Components are located at resources/views/components and are either Laravel Blade or VueJS components.

To show a component use a component() helper:

component('MyComponent')
    ->is('small') // Optional CSS modifier, adds a MyComponent--small class
    ->is('red') // Modifiers can be chained
    ->with('data1', 'Hello') // Passing a variable, similar to view()->with()
    ->with('data2', 'World'); // Variables can be chained

If there are both Blade and Vue components with the same name, Blade is preferred. You can request a Vue template by chaining a ->vue() method.

Making a component

To make a Blade component, run

php artisan make:component MyComponent

and follow the directions.

To make a Vue component run

php artisan make:component MyComponent --vue

Component CSS

Class naming conventions

We use a hybrid BEM / SUIT naming convention:

Blocks:

.Component {
}
.AnotherComponent {
}

Elements (note the spacing):

.Component__element {
}
.AnotherComponent__anotherElement {
}

Modifiers

.Component--modifier {
}
.AnotherComponent--anotherModifier {
}

Style variables in CSS

Variables are located in /resources/views/styles/styles.js

For CSS, the variables are automatically available:

.Component {
    height: $spacer;
}

Style variables in PHP

Variables in /resources/views/styles/styles.js are exported to config/styles.php during fontent build time and can can be used in PHP files and Blade templates using styles() helper:

<div style="height: {{ styles('spacer') }}">

Style variables in Vue

Variables in /resources/views/styles/variables.json can be used in Vue templates like this:

<div :style="{ height: $styles.spacer }">

and in methods like this

this.$styles.spacer

Fonts

Fonts for headings

Also, it's recommended to reduce contrast and use lighter font colors:

.Component__title {
    font: $font-heading-lg;
    color: $gray-dark;
}

Fonts for shorter plain texts

Use the $font-text-xs | $font-text-sm | $font-text-md | $font-text-lg variables.

.Component__description {
    font: $font-text-md; // The recommended body size
    color: $gray-dark; // For reduced contrast
}

Fonts for longer texts with markup

Use the dedicated Body component:

component('Body')->with('body', $your_html_content);

Third party CSS

When using third party libraries one can import it's CSS from node_modules directory:

@import 'somelibrary/dist/somelibrary.css';

Regions

API

Regions are located at app/Http/Regions and are simple PHP classes to extract rendering specific code chunks out of controllers.

To show a component use a region() helper:

region('MyComponent', $parameter1, $parameter2); // etc

Making a region

To make a region, run

php artisan make:region MyRegion