triplea-game / triplea

TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.
https://triplea-game.org/
GNU General Public License v3.0
1.34k stars 394 forks source link

Europe Improved ready to be added #12947

Open VictoryFirst2 opened 3 hours ago

VictoryFirst2 commented 3 hours ago

Hi, I have made improvements to the module for Axis & Allies: Europe (1999), called "Europe - Beta". Almost every single bug has been fixed and new features have been added to make as many things as possible governed by the engine.

Here is my repository: https://github.com/VictoryFirst2/europe_improved

The original module can be found in this repository: https://github.com/triplea-maps/europe

beelee1 commented 3 hours ago

Hi Victory

You have this as a Issue. You need to make a Pull Request to the repo you want to change. And then make a PR for it.

Issues are for bugs/user problems and probably other stuff :)

VictoryFirst2 commented 3 hours ago

Oh, it said in this guide I needed to create an issue xD: https://docs.google.com/document/d/1FfF7N0srp9QG0_if5D-c1d1Aa1QTttdhxgm1GBh3pI4/edit?tab=t.0

VictoryFirst2 commented 3 hours ago

So how do I create a pull request? It should be a separate module, not replace an existing module.

beelee1 commented 2 hours ago

yea so go to the repo and fork it

then make your changes and make a PR I think lol

beelee1 commented 2 hours ago

go to our repo and make a minor change. Change the xml by 1 number

Should be a big green buttuon show up hit that

beelee1 commented 2 hours ago

there might be access stuff going on.

You got access to EXP so try a minor one there

beelee1 commented 2 hours ago

Oh ? You want a new game basically then. Gotta make a repo from scratch and all the stuff to it then do a yaml PR

VictoryFirst2 commented 2 hours ago

Ah so I just need to edit the yaml? But shouldn't my repo be added to triplea maps?

beelee1 commented 2 hours ago

Oh yea that link is outdated

beelee1 commented 2 hours ago

hmm I struggle with this. Lets @RogerCooper if he can help