search

tristanlabelle / swift-winrt

A Swift Projection for WinRT APIs
MIT License
20 stars 2 forks source link

TristanLabelle.SwiftWinRT.0.0.0.nupkg not being built. #395

Closed Noemata closed 2 days ago

Noemata commented 3 days ago

The TristanLabelle.SwiftWinRT.0.0.0.nupkg is not being built. I had the same issue last time. I wound up running the powershell command line manually to get this done, but I see you've moved things around, so I'm not sure where I should execute the build of this from. I don't think you factored this into your build process/instructions.

Everything else is building VERY smoothly with the latest. No problem selecting the correct Win SDK. Do I have to worry about the Swift compiler bug when building the generator? I think it's OK, but I didn't get to the end of the build on the Interop side because of the nuget package creation issue.

As soon as this is resolved, I'll do my first fork of your repo since it looks like you're basically there with this side of the house. Having forks helps with visibility on GitHub.

Please advise.

Noemata commented 3 days ago

Oh, and I like the tweaks to build steps. Nice!

tristanlabelle commented 2 days ago

Background: The current method of building a nupkg and copying it to swift-winui-sample is a temporary thing while I'm standing up both repositories. Once things work, I will start publishing this swiftwinrt package to nuget.org, and swift-winui-sample will download it from there.

So I'm not building the nupkg by design. I provided a CMake target as a helper for local development, but it's not part of the ALL target so it won't be built by default. You can build it explicitly using ninja -C build\debug\Generator NuGetPackage, or equivalent CMake invocation, but note that this target is in the Generator-subbuild folder.

Do I have to worry about the Swift compiler bug when building the generator?

No, the bug only impacts to the generated code. In this repo, it impacts InteropTests (which uses the code generator), but the build will make a dummy Swift compiler invocation to verify whether it is subject to the bug, and then pass the correct flag when generating for InteropTests.

I could implement a similar scheme for swift-winui-sample, although I might have found a better way to avoid the bug (#392)

Noemata commented 2 days ago

Yeah, that's fine. Just wanted to bring it to your attention in case this was not intended. I'm OK with the way it is at present. You can leave it this way.