trivago / chapi

chronos & marathon console client - Manage your jobs like a git repository
MIT License
14 stars 10 forks source link

Fix health check defaults. Port defaults to none(null in php) #76

Closed bidesh closed 7 years ago

bidesh commented 7 years ago

In the case where both portIndex and port is provided, the port takes higher priority. If defaulting to 0, then the health check will be tried in port 0 (not $PORT0!). This is not right. Checking with the documentation, it seems the default value for a port is none (null comes closest in php). So set its default value to null and remove it during jsonSerialize.

Also, sets a bunch of other default values in HealthCheck subentity.