search

troglobit / finit

Fast init for Linux. Cookies included
https://troglobit.com/projects/finit/
MIT License
622 stars 61 forks source link

Add support for optional reboot delay #341

Closed troglobit closed 1 year ago

troglobit commented 1 year ago

Ping @JackNewman12, here's the alternative implementation of your PR, #334, making the delay optional, and possible to enable per system.

JackNewman12 commented 1 year ago

Looks good to me! Haven't tested it myself yet but the changes seem harmless enough.

Default of zero seems OK to me, although I'd have to check out other embedded inits and see what they use. I wonder how common ubifs and jffs2 are. 🤔

Nice work!

troglobit commented 1 year ago

Thanks, pretty straight forward.

Yeah if you could check how other inits do it, it'd be very appreciated.

troglobit commented 1 year ago

When you've tested this, I propose we close #334 and merge this.

JackNewman12 commented 1 year ago

LGTM!