Fix issues reported by PVS-Studio

troydhanson / uthash

C macros for hash tables and more

Other

4.18k stars 926 forks source link

Fix issues reported by PVS-Studio #172

Closed silvioprog closed 3 years ago

silvioprog commented 5 years ago

V522 There might be dereferencing of a potential null pointer 'str->buf'.
V522 There might be dereferencing of a potential null pointer '(str->buf)->d'.

silvioprog commented 5 years ago

Any chance to apply the changes? :confused:

Quuxplusone commented 3 years ago

It seems like the only two diffs left in this PR are handling "s->d might be null, if oom() is a no-op"; but oom() shouldn't ever be a no-op — it should exit or abort or longjmp — and so I think there's nothing left to do here. I'm closing this; if there are any remaining/new static-analyzer issues, please open a new issue/PR.