search

tru-hy / rpeakdetect

MIT License
31 stars 14 forks source link

Your algorithm in neurokit #1

Closed DominiqueMakowski closed 7 years ago

DominiqueMakowski commented 7 years ago

@jampekka I just added your algorithm in the neurokit package (see here) as a possible parameter for ecg processing. It's mostly left untouched (aside from some minor adaptations). I hope it doesn't bother you. Please feel free to make any comments/suggestions/modifications :)

jampekka commented 7 years ago

Great, doesn't bother in the least! The implementation could be quite a bit faster, especially by using proper bandpass and some indexing tricks for the parameter estimation. But I'm glad it's of use!

DominiqueMakowski commented 7 years ago

Perfect thanks. I'm also wondering if you would have any ideas on how to implement a proper P, Q, S and T waves detector? For the peaks, but also onsets and ends of the waves?

jampekka commented 7 years ago

Sorry, I've been busy with other things. I'd say some kind of a model-based deconvolution thing would be the most principled way. Unfortunately I'm not currently working on ECG-signals, and haven't really given this much thought.