Adds support for git-based catalogs, explicit git-based modules, managed catalogs, and fixes build without pkg_mgmt feature set

trueagi-io / hyperon-experimental

MeTTa programming language implementation

https://metta-lang.dev

MIT License

151 stars 49 forks source link

Adds support for git-based catalogs, explicit git-based modules, managed catalogs, and fixes build without pkg_mgmt feature set #691

Closed luketpeterson closed 5 months ago

luketpeterson commented 6 months ago

Adds support for git-based catalogs, explicit git-based modules, and fixes build without pkg_mgmt feature set.

Currently the OpenSSL dependency is on by default. If we want to make it a build-time switch at the CMake level, we will need to feature-gate the requirements in ./python/CMakeLists.txt, as well as changing whether the "git" feature is passed to the cargo library build.

~~Currently we don't have any features that require coordinate between CMake and cargo so I wasn't sure how you want to handle that~~

the GIT CMake option will enable or disable git support. It is on by default. To disable it, pass -DGIT=OFF to cmake

vsbogd commented 6 months ago

The major one is https://github.com/trueagi-io/hyperon-experimental/pull/691#discussion_r1610922376 I still going through files but decided to leave comments which I already have to discuss them.

luketpeterson commented 5 months ago

I looked at all changes you made they are ok, but I am not sure what do you think about comments left unanswered?

There are several outstanding discussion points where there are several good options available and I wanted your feedback on your preference.

Should "optional builtin" modules, like catalog access operations, be loaded directly or via the catalog / pkg_mgmt system? https://github.com/trueagi-io/hyperon-experimental/pull/691#discussion_r1610899402
Do you think additional changes to the catalog management atoms are an improvement? https://github.com/trueagi-io/hyperon-experimental/pull/691#discussion_r1610922376

There are several other points you raised where I don't believe, on balance, additional change is justified. To each of those I commented to that effect.

vsbogd commented 5 months ago

You are saying you commented the questions but I don't see these comments. Is it possible you didn't publish them? May be it is some GitHub glitch.

luketpeterson commented 5 months ago

You are saying you commented the questions but I don't see these comments. Is it possible you didn't publish them? May be it is some GitHub glitch.

Agh! Sorry. I didn't realize I had to "submit" the comments... I've never needed to do that before.