search

trufflesuite / truffle

:warning: The Truffle Suite is being sunset. For information on ongoing support, migration options and FAQs, visit the Consensys blog. Thank you for all the support over the years.
https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat?utm_source=github&utm_medium=referral&utm_campaign=2023_Sep_truffle-sunset-2023_announcement_
MIT License
14.02k stars 2.31k forks source link

Truffle decoder bug #5053

Closed fredlacs closed 2 years ago

fredlacs commented 2 years ago

Issue

Truffle decoder hits an unexpected undefined when parsing a tx on rinkeby.

Steps to Reproduce

When attempting to bridge eth from ethreum to arbitrum, the truffle decoder isn't able to parse the outboundTransfer function

You can reproduce this by going to https://bridge.arbitrum.io/ and trying to bridge eth while connected to the rinkeby network

Here is the tx where this happened https://rinkeby.etherscan.io/tx/0x5309d0f7fa7b2b1f8c85617fbbbd22217d88eae2065ef555d46a3003cf6c8117

Expected Behavior

Expected the truffle decoder to appropriately handle the function provided

Actual Results

"Cannot read property of undefined" telegram-cloud-photo-size-4-5958365184819050304-y

haltman-at commented 2 years ago

So it looks like you're reporting an issue with MetaMask's Transaction Insight, rather than Truffle Decoder directly? That said, it sure looks like an issue with Truffle Decoder, I have to admit. On the other hand, I can't seem to reproduce this using only @truffle/decoder and @truffle/fetch-and-compile. So, I don't know what's wrong here. Have you tried reporting this to MetaMask? Do you have any further reproduction information?

I can try reproducing this some more later, but for now I'm not encountering an issue when I just use Truffle Decoder directly, rather than as part of Transaction Inisght.

haltman-at commented 2 years ago

Hm, hold on, the output that I'm getting doesn't seem right, even if it's not the same problem you're getting. I guess I'll go back and take a second look at this. That said, you still might want to try reporting this to MetaMask.

haltman-at commented 2 years ago

Yeah, after fixing the problem I was getting due to setting things up wrong, so I'm actually getting a sensible decoding now, I'm still not getting the problem using Truffle Decoder alone. This may be a problem with MetaMask; not sure.

sukanyaparashar commented 2 years ago

Hi @fredlacs . Can you please let us know if you are still facing this issue?

dongmingh commented 2 years ago

Hi @fredlacs We will close this one for issue maintenance. Please open an new issue if you still have this issue. Thanks.