trungn1992 / httplib2

Automatically exported from code.google.com/p/httplib2
0 stars 0 forks source link

Http.add_credentials should not accept unicode #234

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Http.add_credentials(u'username', u'password')
2. Set request body to utf8-encoded str
3. Execute request

What is the expected output? What do you see instead?

Expect either add_credentials to encode username and password to ut8, or to 
raise an exception. What happens instead is, it blows up on step 3  trying to 
concatenate unicode (headers) and str (body). 
The problem took some time to track down. Failing early at add_credentials() 
would help a lot.

What version of the product are you using? On what operating system?

httplib2 0.7.6 on Ubuntu 10.04. 

Original issue reported on code.google.com by cuu...@gmail.com on 7 Nov 2012 at 12:08