Closed szszszsz closed 5 years ago
Thanks! Will add a skipif for solokeys since our initial model truncates displayName
@conorpp
In case you have planned to add a simple skip, I think xfail
might be a better choice instead, since it would mean an intent to fix the mentioned test case, and would warn (with XPASS
) if it suddenly starts working. Leaving the decision to you.
Edit: Vendor-based tests looks actually better in the end for my use-case. Let's leave skipif
.
Yes I think xfail is more clear, but since it's SoloKey specific and there's no "xfailif" I went with skipif.
Add tests for:
Related: https://github.com/solokeys/solo/issues/158#issue-426613303 https://github.com/Nitrokey/nitrokey-fido2-firmware/issues/15
Edit: not tested on hardware yet