Check FIDO2 fields lengths

trussed-dev / fido2-tests

Test suite for FIDO2, U2F, and other security key functions

Other

48 stars 38 forks source link

Check FIDO2 fields lengths #10

Closed szszszsz closed 5 years ago

szszszsz commented 5 years ago

Add tests for:

checking the supported minimum required lengths of the RK fields;
checking the maximum allowed RK assertion list capacity for the given RP.

Edit: not tested on hardware yet

[ ] test on hardware

conorpp commented 5 years ago

Thanks! Will add a skipif for solokeys since our initial model truncates displayName

szszszsz commented 5 years ago

@conorpp In case you have planned to add a simple skip, I think xfail might be a better choice instead, since it would mean an intent to fix the mentioned test case, and would warn (with XPASS) if it suddenly starts working. Leaving the decision to you.

Edit: Vendor-based tests looks actually better in the end for my use-case. Let's leave skipif.

conorpp commented 5 years ago

Yes I think xfail is more clear, but since it's SoloKey specific and there's no "xfailif" I went with skipif.