trussed-dev / fido2-tests

Test suite for FIDO2, U2F, and other security key functions
Other
48 stars 38 forks source link

Skip standard/fido2/pin/ tests if device does not support clientPin #17

Open andrewkozlik opened 5 years ago

andrewkozlik commented 5 years ago

The tests in tests/standard/fido2/pin/ assume that the authenticator supports clientPin. Authenticators which verify the user directly on the device, such as Trezor, do not support clientPin, so they will fail these tests. The tests should be run only if the clientPin option is present in the authenticatorGetInfo response. I am not sure how to implement this, because apparently you can't do @pytest.mark.skipif() based upon the info fixture.